Broadleaf Commerce Discussion Forums

Hi guys,

there is a problem with paypal module (version 2.2.0-SNAPSHOT) and broadleaf version 2.2.1-SNAPSHOT :



In fact the method initializeOrderForCheckout and processFailedOrderCheckout doesn't exist anymore in BroadleafCheckoutController in BLC 2.2.1-SNAPSHOT but you still use it in method paypalProcess of BroadleafPayPalController.

Can you make a new version of paypal module (2.2.1-SNAPSHOT) without these methods and with BLC 2.2.1-SNAPSHOT as dependency ?

Thanks in advance

You are correct; looking at this today, I'll update you when we've got a fix. I think this is just a matter of merging into the right branches because we made a similar fix for the 2.0.x line.

Ok thanks Phillip !

Denis,

There were quite a few things wrong with the Paypal repository in regards to branches and merging. I have finished what I see to be the necessary changes that needed to happen to right the sinking ship, but it might take a bit of time before we get our nexus to reflect the changes (like a couple of days). I need to check with others tomorrow to investigate who else my changes effect.

However, for your purposes, you should be targeting the 2.3.0-SNAPSHOT version of the Paypal module. This is currently referring to (and has the necessary fix for) the 2.2.1-SNAPSHOT version of the framework. This is currently available in the 'develop-2.3.x' branch on GitHub for the Paypal module.

As I said, the branches/commits on the Paypal module are a little crazy at the moment. We should have these cleaned up soon, and I will also let you know when we get the deployment out to our nexus.

Thanks Phillip , for now i switch to the 2.3.0-SNAPSHOT version of the Paypal module and i will try it ASAP !

Just for information why have you removed these 2 methods ?

- initializeOrderForCheckout is in the workflow now ==> OK
- but where is the process responsible to rollback the order status (processFailedOrderCheckout ) if the payment failed in this new version?

It was changed in this commit: https://github.com/BroadleafCommerce/Br ... fd684bf9aa

The only reason that we had a 'processFailedOrderCheckout' is to reset the order status back to 'in process' and the order number to null. The only reason that we needed to do that, is because we set these values prior to invoking the checkout workflow. Now, the order status and order number is set in the 'CompleteOrderActivity' at the end of the checkout workflow, so now we're guaranteed that the order status and order number will not be set until the entire checkout workflow has been completed. Thus, no need for a customization of resetting the order number and status.

Thanks, i understand better now

Hi Phillip,

The Paypal 2.3.0-SNAPSHOT is not available on your nexus : http://nexus.broadleafcommerce.org/nexu ... eaf-paypal

Can you deploy it please ?

Thanks

up

The 2.3.0-SNAPSHOT version is now deployed to the BLC nexus.