Page 1 of 1

build-sql task (bug corrected)

Posted: Mon Feb 20, 2012 7:12 pm
by karim.hj
Hi ,

I’ve downloaded the maven archetype from ‘develop*’ branch so as to use/test the ddl export task you wrote.
https://github.com/BroadleafCommerce/BroadleafCommerceMavenArchetypes/tree/develop
(*I know it’s not recommended practice but my curiosity was too high)

It did not work at first so I did some changes on pom/build files so as to export successfully ddl statements.
I am curious to know if it was working on your machines without the little modifications I made.

(more readable zipped document attached)
build-sql.zip
Trace logs, files and bug fix
(82.3 KiB) Downloaded 495 times


build.xml

Code: Select all

                    <intersect>
                       <fileset refid="libDir" /> --> <fileset refid="pomDeps" />
                        <fileset refid="pomDeps" />
                    </intersect>


Because of a missing servlet class exception (provided by jetty i suppose)

pom.xml

Code: Select all

<dependency>
                <groupId>javax.servlet</groupId>
                <artifactId>servlet-api</artifactId>
                <version>2.5</version>
                <type>jar</type>
                <scope>provided-->compile</scope>
            </dependency>
            <dependency>
                <groupId>javax.servlet.jsp</groupId>
                <artifactId>jsp-api</artifactId>
                <version>2.1</version>
                <type>jar</type>
                <scope>provided-->compile</scope>
            </dependency>


i 've relauched this ant task with with options

Code: Select all

-XX:MaxPermSize=256M -Xmx512M
(to avoid Memory exception)
Eventually it worked.

> I had the impression to do little bad tricky things to make it work. Is it normal, or I missed something/bad configuration ?

By the way your work on Broadleaf is quite impressive !

Re: build-sql task (bug corrected)

Posted: Tue Feb 21, 2012 12:55 pm
by jefffischer
I think you were working with the code before I had an opportunity to add some additional fixes over the weekend. I was able to delete my maven repository, mvn install my archetype-based project and then execute the build-sql task without any errors. I can see how those memory settings may be necessary, so I added a comment to the task to make people aware.