Page 1 of 1

SandboxConnection compile error [FIXED]

Posted: Wed Oct 10, 2012 12:27 pm
by alexhutnik
When I clone BroadleafCommerce-2.0.0-RC1-x and do a `mvn clean compile` I get an error:

Code: Select all

BroadleafCommerce/admin/broadleaf-open-admin-platform/src/main/java/org/broadleafcommerce/openadmin/server/service/persistence/datasource/SandBoxConnection.java:[40,7] error: SandBoxConnection is not abstract and does not override abstract method getNetworkTimeout() in Connection


In STS, I see the same error in the Markers list. If I go to that class and add the unimplemented methods, the project compiles fine.

Re: SandboxConnection compile error

Posted: Wed Oct 10, 2012 2:49 pm
by phillipuniverse
In regards to your specific problem, what version of Java are you using? Looks like that method on java.sql.Connection (getNetworkTimeout()) is only available in Java 7 (Java 6 Connection class definition Java 7 Connection class definition). We have not yet done the due diligence in verifying that Broadleaf is good to go on Java 7. If you instead tone down the Java version to Java 6 you shouldn't have any issues.

Also, we highly recommend using the 2.0.1-GA which was released at the end of last week rather than target an RC version.

Re: SandboxConnection compile error

Posted: Wed Oct 10, 2012 3:04 pm
by alexhutnik
I switched to 1.6 for compiling and it seems to have fixed the issue.

What git branch holds 2.0.1-GA? I didn't see anything on github.

Re: SandboxConnection compile error

Posted: Wed Oct 10, 2012 3:15 pm
by phillipuniverse
This is on maven central so you should just be able to reference that version in the pom.

The master branch is currently on 2.0.1-GA. This branch always reflects the latest GA version.

Re: SandboxConnection compile error

Posted: Wed Oct 10, 2012 3:22 pm
by alexhutnik
Yup, ok got it. My remote was mis-configured so I wasn't able to see the newest stuff.

Re: SandboxConnection compile error

Posted: Wed Apr 03, 2013 8:26 pm
by sslavic
JDK 6 is EOL.
Created pull request which deletes this class.

Re: SandboxConnection compile error

Posted: Fri Apr 19, 2013 4:06 pm
by jefffischer
A pull request was just merged into 2.2 that should have addressed this java 7 issue. It should be in the next 2.2.1-SNAPSHOT nightly build.